Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DOMTimeStamp #1021

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Remove DOMTimeStamp #1021

merged 1 commit into from
Oct 19, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 9, 2021 •
edited by pr-preview bot
Loading

Closes #2

DOMTimeStamp becomes EpochTimeStamp in HR-TIME.
w3c/hr-time#124

Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1735096

Preview | Diff

@marcoscaceres marcoscaceres mentioned this pull request Sep 9, 2021
Closed
@marcoscaceres marcoscaceres marked this pull request as ready for review October 9, 2021 08:40
@marcoscaceres
Copy link
Member Author

EpochTimeStamp is now in HR-Time.

@marcoscaceres
Copy link
Member Author

Filed meta Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1735096 ... along with various dependent changes.

@marcoscaceres marcoscaceres mentioned this pull request Oct 11, 2021
Merged
4 tasks
@marcoscaceres
Copy link
Member Author

WebKit has implemented EpochTimeStamp (and removed DOMTimeStamp): https://bugs.webkit.org/show_bug.cgi?id=231496

@marcoscaceres
Copy link
Member Author

Chromium is also in the process of being updated: https://bugs.chromium.org/p/chromium/issues/detail?id=1258466

domenic
domenic approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all uses have been eliminated! https://dontcallmedom.github.io/webidlpedia/names/DOMTimeStamp.html

@domenic domenic merged commit 5c3cecd into whatwg:main Oct 19, 2021
@marcoscaceres marcoscaceres deleted the rm_dom_timestamp branch October 19, 2021 21:51
@inexorabletash inexorabletash mentioned this pull request Oct 19, 2021
Closed
@dontcallmedom
Copy link
Contributor

given dontcallmedom/webidlpedia#24, here is the list of remaining DOMTimeStamp mentions:

@domenic
Copy link
Member

domenic commented Oct 20, 2021

Thank you, @dontcallmedom!

Do people think we should revert this for now, since some of those discussions are still ongoing? Or just try to forge ahead? I'll file a Notifications API issue...

@domenic domenic mentioned this pull request Oct 20, 2021
Closed
@marcoscaceres
Copy link
Member Author

Personally, I think we should forge ahead. Changes have landed in WebKit, there are patches really close to landing in Gecko, and bugs have been filed on Chromium (not sure about the status of the implementation tho).

@marcoscaceres
Copy link
Member Author

Sent PR to WebRTC.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 16, 2021
@marcoscaceres
Bug 1735098 - Implement EpochTimeStamp from HR-Time r=edgar
04d9c2d 
Add the EpochTimeStamp, which can be used to incrementally rename/remove DOMTimeStamp. See also w3c/hr-time#124 and whatwg/webidl#1021

Differential Revision: https://phabricator.services.mozilla.com/D128030
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 16, 2021
@marcoscaceres
Bug 1735098 - Implement EpochTimeStamp from HR-Time r=edgar
f1db7c6 
Add the EpochTimeStamp, which can be used to incrementally rename/remove DOMTimeStamp. See also w3c/hr-time#124 and whatwg/webidl#1021

Differential Revision: https://phabricator.services.mozilla.com/D128030
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 16, 2021
@marcoscaceres
Bug 1735098 - Implement EpochTimeStamp from HR-Time r=edgar
0f403e1 
Add the EpochTimeStamp, which can be used to incrementally rename/remove DOMTimeStamp. See also w3c/hr-time#124 and whatwg/webidl#1021

Differential Revision: https://phabricator.services.mozilla.com/D128030
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 18, 2021
@marcoscaceres
Bug 1735098 - Implement EpochTimeStamp from HR-Time r=edgar
4bca1a9 
Add the EpochTimeStamp, which can be used to incrementally rename/remove DOMTimeStamp. See also w3c/hr-time#124 and whatwg/webidl#1021

Differential Revision: https://phabricator.services.mozilla.com/D128030
@sideshowbarker sideshowbarker mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOMTimeStamp confusion
3 participants
@marcoscaceres @dontcallmedom @domenic